Conversation
daobrien
requested changes
Aug 29, 2024
Collaborator
daobrien
left a comment
daobrien
left a comment
There was a problem hiding this comment.
A couple of suggestions but mostly ok.
en-US/M.xml
Outdated
| <term>mission-critical</term> | ||
| <listitem> | ||
| <para> | ||
| <emphasis>adj.</emphasis> Write hyphenated. |
Collaborator
There was a problem hiding this comment.
Can we standardise on how we write this? E.g., in the style guide right now we tend to use "Write as shown" although I have also seen "Hyphenate as a compound adjective". "Write hyphenated" doesn't really do it for me.
en-US/M.xml
Outdated
| </para> | ||
| <para> | ||
| Use to refer to software or systems that are essential to fulfilling the core purpose of an organization. | ||
| When mission-critical systems fail, the impact on the organization is often immediate and always severe. |
Collaborator
There was a problem hiding this comment.
Consider removing "on the organization". It's not wrong, but the immediate impact might be felt elsewhere. Consider the example of flight tracking software. Yes, that would impact the org, but it would impact planes and passengers first, and worst. wdyt?
daobrien
reviewed
Aug 30, 2024
en-US/M.xml
Outdated
| <listitem> | ||
| <para> | ||
| <emphasis>adj.</emphasis> Write hyphenated. | ||
| <emphasis>adj.</emphasis> Write the term hyphenated. |
Collaborator
There was a problem hiding this comment.
Suggested change
| <emphasis>adj.</emphasis> Write the term hyphenated. | |
| <emphasis>adj.</emphasis> Write as shown. |
Collaborator
There was a problem hiding this comment.
This is what I mean. Thanks.
daobrien
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.